Skip to content

refactor(cx-api): bump cli <=> cdk protocol version#2956

Merged
eladb merged 4 commits intomasterfrom
benisrae/bump-cx
Jun 23, 2019
Merged

refactor(cx-api): bump cli <=> cdk protocol version#2956
eladb merged 4 commits intomasterfrom
benisrae/bump-cx

Conversation

@eladb
Copy link
Copy Markdown
Contributor

@eladb eladb commented Jun 20, 2019

following up on #2922, manifest may include "env" that indicates unknown-account/unknown-region,
which will cause old CLIs to fail, so we must bump the version to ensure compatibility.

BREAKING CHANGE: Previous versions of the CDK CLI will not be fully compatible with this version of the framework and vice versa.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

refactor(cx-api): bump cli <=> cdk protocol version
6683cd2 
following up on #2922, manifest may include "env" that indicates unknown-account/unknown-region,
which will cause old CLIs to fail, so we must bump the version to ensure compatibility.

BREAKING CHANGE: Previous versions of the CDK CLI will not be fully compatible with this version of the framework and vice versa.
@eladb eladb requested a review from a team as a code owner June 20, 2019 12:16
@eladb eladb requested a review from SoManyHs as a code owner June 23, 2019 19:36
@eladb eladb merged commit 8ab84ec into master Jun 23, 2019
@eladb eladb deleted the benisrae/bump-cx branch June 23, 2019 20:31
This was referenced Aug 22, 2019
Open
Open
Open
Open
Open
@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 23, 2019
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 23, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

This was referenced Dec 12, 2019
Closed
Closed
Closed
Merged
Closed
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Jan 20, 2020
Closed
Closed
This was referenced Sep 24, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
@NOUIY NOUIY mentioned this pull request Oct 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rix0rrr rix0rrr rix0rrr approved these changes

@SoManyHs SoManyHs Awaiting requested review from SoManyHs

+1 more reviewer

@RomainMuller RomainMuller RomainMuller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

contribution/core This is a PR that came from AWS.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@eladb @RomainMuller @rix0rrr @NGL321