fix(sns): contentBasedDeduplication is always false for imported topic#29542
fix(sns): contentBasedDeduplication is always false for imported topic#29542mergify[bot] merged 12 commits intoaws:mainfrom
Conversation
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
|
Exemption request: I don't believe an integration test is needed here. |
e427903 to
68f5d7b
Compare
|
@lpizzinidev This should be better now.. |
lpizzinidev
left a comment
There was a problem hiding this comment.
Thanks for the changes 👍
Left some comments for further adjustments.
Also, can you please add integration test coverage for the Topic.fromTopicArn and Topic.fromTopicAttributes methods?
|
@lpizzinidev This should be better now. |
lpizzinidev
left a comment
There was a problem hiding this comment.
Thanks 👍
Looks good to me, just a final adjustment on the integration tests is needed in my opinion
packages/@aws-cdk-testing/framework-integ/test/aws-sns/test/integ.sns.ts
Outdated
Show resolved
Hide resolved
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Thank you @msambol for your contribution, as per my understanding content based deduplication is available only for the FIFO queue, so if we are allowing users to set this value for imported topics, they might mistakenly set it for standard queue and face issue during deployment. Could we add validation that this is being set from attributes only in case in fifo queue. |
Great catch! Updated. |
shikha372
left a comment
There was a problem hiding this comment.
LGTM .. Thank you @msambol for contributing and @lpizzinidev for review
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Closes #29532.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license