feat(pipes-sources): add Kinesis and DynamoDB#29476
Conversation
packages/@aws-cdk/aws-pipes-sources-alpha/lib/deadLetterConfig.ts
Outdated
Show resolved
Hide resolved
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
d101e30 to
5775e19
Compare
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
5404f66 to
0760175
Compare
|
@nmussy Feel like reviewing a big one? 😄 |
|
I'll have a look on Monday 👍 |
nmussy
left a comment
There was a problem hiding this comment.
Still need to take a look at the tests, but I already went through the code and docs 👍
packages/@aws-cdk/aws-pipes-sources-alpha/lib/deadLetterConfig.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-pipes-sources-alpha/lib/deadLetterConfig.ts
Outdated
Show resolved
Hide resolved
3c66072 to
89b108b
Compare
cbf852d to
50dbcec
Compare
175b6da to
ecba4fa
Compare
|
@GavinZZ Thanks for the review! I know this is a large one. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
GavinZZ
left a comment
There was a problem hiding this comment.
LGTM, thank you for the effort and patience!
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Closes #29378, #29377.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license