Skip to content

chore(synthetics): deprecate nodejs runtimes#29472

Merged
mergify[bot] merged 3 commits intoaws:mainfrom
msambol:canary-runtimes
Mar 14, 2024
Merged

chore(synthetics): deprecate nodejs runtimes#29472
mergify[bot] merged 3 commits intoaws:mainfrom
msambol:canary-runtimes

Conversation

@msambol
Copy link
Copy Markdown
Contributor

@msambol msambol commented Mar 13, 2024 •
edited
Loading

Per this doc, these 5 runtimes were deprecated on March 8, 2024.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the star-contributor [Pilot] contributed between 25-49 PRs to the CDK label Mar 13, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team March 13, 2024 17:09
@github-actions github-actions bot added the p2 label Mar 13, 2024
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 13, 2024
@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Mar 13, 2024
gracelu0
gracelu0 previously approved these changes Mar 14, 2024
View reviewed changes
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 14, 2024
@msambol
Copy link
Copy Markdown
Contributor Author

msambol commented Mar 14, 2024

@Mergifyio refresh

@msambol
Copy link
Copy Markdown
Contributor Author

msambol commented Mar 14, 2024

@gracelu0 do you mind merging in main here?

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 14, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 14, 2024

refresh

✅ Pull request refreshed

@mergify mergify bot dismissed gracelu0’s stale review March 14, 2024 19:21

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 14, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 14, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@msambol
Copy link
Copy Markdown
Contributor Author

msambol commented Mar 14, 2024

@gracelu0 I screwed something up 🤦🏼‍♂️ Do you mind re-approving?

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 14, 2024

refresh

✅ Pull request refreshed

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 14, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 14, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 14, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@paulhcsun
Copy link
Copy Markdown
Contributor

paulhcsun commented Mar 14, 2024

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 14, 2024

update

☑️ Nothing to do

Details
  • queue-position=-1 [📌 update requirement]
  • #commits-behind>0 [📌 update requirement]
  • -closed [📌 update requirement]
  • -conflict [📌 update requirement]

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Mar 14, 2024

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 11d332c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 3c1307e into aws:main Mar 14, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 14, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@github-actions github-actions bot mentioned this pull request Mar 18, 2024
Closed
@github-actions github-actions bot mentioned this pull request Apr 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@go-to-k go-to-k go-to-k approved these changes

@gracelu0 gracelu0 gracelu0 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

p2 star-contributor [Pilot] contributed between 25-49 PRs to the CDK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@msambol @paulhcsun @aws-cdk-automation @go-to-k @gracelu0