feat(events-targets): support for RedshiftDataParameters#29462
Conversation
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
…azon-eventbridge' of https://github.com/Rizxcviii/aws-cdk into add-scheduling-a-redshift-query-to-event-targets-for-amazon-eventbridge
RedshiftDataParameters without the need for an L1 escape hatch
RedshiftDataParameters without the need for an L1 escape hatchRedshiftDataParameters
|
Clarification request: One workflow is failing, and I am not sure what the reason is? |
paulhcsun
left a comment
There was a problem hiding this comment.
Hi @Rizxcviii, apologies for leaving this review without a follow-up, thank you for making the contribution! I'll be taking over the review for this PR and I've left some comments.
Pull request has been modified.
…gets-for-amazon-eventbridge
paulhcsun
left a comment
There was a problem hiding this comment.
Nice work @Rizxcviii!
And thanks for helping the discussion @manmartgarc!
|
@Mergifyio update |
…gets-for-amazon-eventbridge
✅ Branch has been successfully updated |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
…gets-for-amazon-eventbridge
|
@paulhcsun, not too sure, but it seems that it's not an issue with my PR right? |
|
@Mergifyio update |
✅ Branch has been successfully updated |
…gets-for-amazon-eventbridge
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #15712.
Closes #31017.
Reason for this change
RedshiftDataParametersallow for a redshift query to be scheduled. This feature adds that inDescription of changes
Added in the event target and the parameter into
aws-eventsDescription of how you validated changes
Added unit tests + integration test
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license