Skip to content

feat(ecs-patterns): support securityGroups in NetworkLoadBalancedFargateService#29431

Merged
mergify[bot] merged 8 commits intoaws:mainfrom
wafuwafu13:nlb-fargate-sg
Mar 13, 2024
Merged

feat(ecs-patterns): support securityGroups in NetworkLoadBalancedFargateService#29431
mergify[bot] merged 8 commits intoaws:mainfrom
wafuwafu13:nlb-fargate-sg

Conversation

@wafuwafu13
Copy link
Copy Markdown
Contributor

@wafuwafu13 wafuwafu13 commented Mar 11, 2024 •
edited
Loading

Issue # (if applicable)

Closes #29430

(related to #29186 (comment))

Reason for this change

We can't specify securityGroups in NetworkLoadBalancedFargateService now.

Description of changes

  • Add securityGroups property to NetworkLoadBalancedFargateServiceProps.
  • Add unit test
  • Add integ test

Description of how you validated changes

  • Pass unit test
  • Pass integ test

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added valued-contributor [Pilot] contributed between 6-12 PRs to the CDK feature-request A feature should be added or improved. p2 labels Mar 11, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team March 11, 2024 08:19
aws-cdk-automation
aws-cdk-automation previously requested changes Mar 11, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@wafuwafu13 wafuwafu13 marked this pull request as draft March 11, 2024 08:55
@wafuwafu13 wafuwafu13 marked this pull request as ready for review March 11, 2024 11:12
@aws-cdk-automation aws-cdk-automation dismissed their stale review March 11, 2024 11:13

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 11, 2024
@github-actions github-actions bot added p1 and removed p2 labels Mar 11, 2024
@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Mar 11, 2024
@xazhao
Copy link
Copy Markdown
Contributor

xazhao commented Mar 12, 2024

The change is pretty straightforward and looks good to me.

Thanks @wafuwafu13 for the contribution. Approving and it will be merged.

xazhao
xazhao previously approved these changes Mar 12, 2024
View reviewed changes
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 12, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 12, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 12, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed xazhao’s stale review March 12, 2024 05:59

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 12, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 13, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 13, 2024
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Mar 13, 2024

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 457e0b5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 00e8a7b into aws:main Mar 13, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 13, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@github-actions github-actions bot mentioned this pull request Mar 18, 2024
Closed
@github-actions github-actions bot mentioned this pull request Apr 1, 2024
Closed
This was referenced May 23, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

+1 more reviewer

@xazhao xazhao xazhao approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

feature-request A feature should be added or improved. p1 valued-contributor [Pilot] contributed between 6-12 PRs to the CDK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ecs-patterns: enable to specify securityGroups in NetworkLoadBalancedFargateService

3 participants

@wafuwafu13 @xazhao @aws-cdk-automation