feat(rds): eliminating the need for explicit secret.grantRead() invokes when using DataAPI with Aurora cluster#29399
Merged
mergify[bot] merged 6 commits intoaws:mainfrom Mar 14, 2024
Conversation
secret.grantRead() invokes when using DataAPIsecret.grantRead() invokes when using DataAPI with Aurora cluster
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This was referenced May 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #29362.
Reason for this change
As discussed there, we should invoke
secret.grantRead()explicitly when using DataAPI with Aurora cluster.Because it's inconvenient for users, I made
secret.grantRead()be invoked withincluster.grantDataApiAccess().Description of changes
cluster.secretfromDatabaseClusterNewtoDatabaseClusterBaseto use it withinDatabaseClusterBase.grantDataApiAccess()secret.grantRead()incluster.grantDataApiAccess()secretproperty toDatabaseClusterAttributesPoints of concern
DatabaseClusterBaseclass is extended byImportedDatabaseClusterclass. Therefore, it is necessary to defineImportedDatabaseCluster.secret.I simply added
secretprops toDatabaseClusterAttributesbut I cannot believe this is the best way.Other ways are..
secretArntoDatabaseClusterAttributesImportedDatabaseCluster.secretbecomes always undefinedDescription of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license