Skip to content

fix: add validation for ALB access log bucket when KMS key is provided#29382

Merged
mergify[bot] merged 14 commits intoaws:mainfrom
shikha372:alb_access_log_bucket
Mar 27, 2024
Merged

fix: add validation for ALB access log bucket when KMS key is provided#29382
mergify[bot] merged 14 commits intoaws:mainfrom
shikha372:alb_access_log_bucket

Conversation

@shikha372
Copy link
Copy Markdown
Contributor

@shikha372 shikha372 commented Mar 6, 2024 •
edited
Loading

Issue # (if applicable)

Closes #22031, #21947.

Reason for this change

Adds a validation with correct error indicating ALB Access log bucket does not support KMS encryption

Description of changes

Currently access logs bucket encryption with KMS is not supported in case of ALB but while deploying it throws an error indicating the failure with bucket permissions.
This validation introduces an upfront check to throw an error if bucket.encryptionKey is defined.
Documentation: https://docs.aws.amazon.com/elasticloadbalancing/latest/application/enable-access-logging.html

Description of how you validated changes

Added unit tests for validation.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team March 6, 2024 19:21
@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p2 labels Mar 6, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Mar 6, 2024
aws-cdk-automation
aws-cdk-automation previously requested changes Mar 6, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@shikha372 shikha372 added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Mar 6, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review March 6, 2024 19:26

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@shikha372 shikha372 marked this pull request as ready for review March 8, 2024 21:01
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 14, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 26, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 26, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 26, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@shikha372
Copy link
Copy Markdown
Contributor Author

shikha372 commented Mar 27, 2024

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 27, 2024

update

❌ Pull request can't be updated with latest base branch changes

Details

Mergify needs the author permission to update the base branch of the pull request.
@shikha372 needs to authorize modification on its head branch.

@shikha372
Copy link
Copy Markdown
Contributor Author

shikha372 commented Mar 27, 2024

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 27, 2024

update

❌ Pull request can't be updated with latest base branch changes

Details

Mergify needs the author permission to update the base branch of the pull request.
@shikha372 needs to authorize modification on its head branch.

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Mar 27, 2024

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: bc25921
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 27, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 2cc2449 into aws:main Mar 27, 2024
@github-actions github-actions bot mentioned this pull request Apr 1, 2024
Closed
@shikha372 shikha372 self-assigned this Apr 27, 2024
This was referenced May 23, 2024
Open
Open
@NOUIY NOUIY mentioned this pull request May 30, 2024
Open
@sakurai-ryo sakurai-ryo mentioned this pull request Jun 20, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

+1 more reviewer

@GavinZZ GavinZZ GavinZZ approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@shikha372 shikha372

Labels

bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/small Small work item – less than a day of effort p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shikha372 @aws-cdk-automation @GavinZZ