Skip to content

chore: add some debugging to regression test skipping#29332

Merged
mergify[bot] merged 3 commits intomainfrom
huijbers/regression-debugging
Mar 1, 2024
Merged

chore: add some debugging to regression test skipping#29332
mergify[bot] merged 3 commits intomainfrom
huijbers/regression-debugging

Conversation

@rix0rrr
Copy link
Copy Markdown
Contributor

@rix0rrr rix0rrr commented Mar 1, 2024

The regression test skipping mechanism doesn't seem to be working. Investigate what's going on by adding print logging.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Mar 1, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team March 1, 2024 09:31
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Mar 1, 2024
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 1, 2024
if [[ -f "$candidate_dir" ]]; then
cp -R "${candidate_dir}/"* "$2"
fi No newline at end of file
if [[ -d "$candidate_dir" ]]; then
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turning -f into -d was the load bearing fix

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: c67c65d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 1, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 0d6ef63 into main Mar 1, 2024
@mergify mergify bot deleted the huijbers/regression-debugging branch March 1, 2024 14:35
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants