feat(codepipeline): `executionMode` property for Pipeline by go-to-k · Pull Request #29148 · aws/aws-cdk

go-to-k · 2024-02-17T15:10:18Z

Issue # (if applicable)

Reason for this change

We would be good to add a new parameter for execution mode.

see:

https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-codepipeline-pipeline.html#cfn-codepipeline-pipeline-executionmode

https://aws.amazon.com/about-aws/whats-new/2024/02/codepipeline-trigger-filters-execution-modes

Description of changes

Add an executionMode parameter to the PipelineProps interface.

Description of how you validated changes

Both unit and integ tests.

Checklist

My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

aws-cdk-automation

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

go-to-k · 2024-02-17T15:15:58Z

packages/aws-cdk-lib/aws-codepipeline/lib/pipeline.ts

+    if (
+      props.executionMode
+      && [ExecutionMode.QUEUED, ExecutionMode.PARALLEL].includes(props.executionMode)
+      && this.pipelineType !== PipelineType.V2
+    ) {
+      throw new Error(`${props.executionMode} execution mode can only be used with V2 pipelines, \`PipelineType.V2\` must be specified for \`pipelineType\``);
+    }
+


I have confirmed that the error occurs when QUEUED or PARALLEL mode is specified in the AWS console.

QUEUED or PARALLEL mode can only be used with V2 pipelines

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

jumic

From my point of view, the PR already looks good. I would suggest adding some descriptions for the execution modes. (Copied from https://docs.aws.amazon.com/codepipeline/latest/userguide/concepts-how-it-works.html)

packages/aws-cdk-lib/aws-codepipeline/lib/pipeline.ts

go-to-k · 2024-03-03T08:12:51Z

@jumic

Thanks for your review. I modified them, could you please check? (The format of line breaks, etc. has been slightly changed.)

jumic

Thanks. LGTM! 👍

gracelu0

LGTM, thank you for your contribution! :)

mergify · 2024-03-07T19:34:11Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Pull request has been modified.

go-to-k · 2024-03-08T07:54:50Z

@gracelu0

Thanks for your approval.
The merge of the main branch caused a difference in the integ test snapshot, so I modified the snapshot again.
Could you please approve it again?

  CHANGED    aws-codepipeline-actions/test/integ.pipeline-type-v2 3.224s
      Resources
[~] AWS::Lambda::Function CustomS3AutoDeleteObjectsCustomResourceProviderHandler9D90184F 
 └─ [~] Code
     └─ [~] .S3Key:
         ├─ [-] 2ec8ad9e91dcd6e7ad6a5c84ffc6c9c05c408aca3b26ceb2816d81043e6c4dc3.zip
         └─ [+] 54e6f07bf3aea46d100719f3b21fe0fb45ae789ee372d42d8cdfb97e21aba96c.zip

mergify · 2024-03-08T19:34:57Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation · 2024-03-08T20:02:53Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: c1fcdba
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2024-03-08T20:03:48Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

go-to-k added 2 commits February 17, 2024 23:42

feat(codepipeline): property for Pipeline

2866e50

validation

abf3501

aws-cdk-automation requested a review from a team February 17, 2024 15:10

github-actions bot added feature-request A feature should be added or improved. p2 distinguished-contributor [Pilot] contributed 50+ PRs to the CDK labels Feb 17, 2024

aws-cdk-automation previously requested changes Feb 17, 2024

View reviewed changes

go-to-k commented Feb 17, 2024

View reviewed changes

Merge branch 'main' into codepipeline-execution-mode

7cf4d8e

github-actions bot added the effort/medium Medium work item – several days of effort label Feb 22, 2024

go-to-k added 3 commits February 22, 2024 19:40

rm a line

c8ff7c5

integ test

5090819

README

6588ed2

go-to-k marked this pull request as ready for review February 22, 2024 11:02

aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Feb 22, 2024

github-actions bot mentioned this pull request Mar 1, 2024

Monthly PR metrics report - Feb 2023 #29328

Closed

jumic suggested changes Mar 1, 2024

View reviewed changes

packages/aws-cdk-lib/aws-codepipeline/lib/pipeline.ts Outdated Show resolved Hide resolved

packages/aws-cdk-lib/aws-codepipeline/lib/pipeline.ts Outdated Show resolved Hide resolved

packages/aws-cdk-lib/aws-codepipeline/lib/pipeline.ts Outdated Show resolved Hide resolved

aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 1, 2024

change docs of ExecutionMode

a896182

go-to-k requested a review from jumic March 3, 2024 08:12

jumic approved these changes Mar 3, 2024

View reviewed changes

aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 3, 2024

gracelu0 previously approved these changes Mar 7, 2024

View reviewed changes

Merge branch 'main' into codepipeline-execution-mode

638d5ce

aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 7, 2024

change snapshots

fc470a6

aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 8, 2024

go-to-k requested a review from gracelu0 March 8, 2024 07:54

gracelu0 approved these changes Mar 8, 2024

View reviewed changes

Merge branch 'main' into codepipeline-execution-mode

c1fcdba

aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 8, 2024

mergify bot merged commit 3bb2944 into aws:main Mar 8, 2024

gustaferiksson mentioned this pull request Jul 18, 2025

aws-pipelines: add executionMode property to CodePipeline construct #35014

Open

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(codepipeline): `executionMode` property for Pipeline#29148

feat(codepipeline): `executionMode` property for Pipeline#29148
mergify[bot] merged 10 commits intoaws:mainfrom
go-to-k:codepipeline-execution-mode

go-to-k commented Feb 17, 2024 •

edited

Loading

Uh oh!

aws-cdk-automation left a comment

Uh oh!

go-to-k Feb 17, 2024

Uh oh!

jumic left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

go-to-k commented Mar 3, 2024

Uh oh!

jumic left a comment

Uh oh!

gracelu0 left a comment

Uh oh!

mergify bot commented Mar 7, 2024

Uh oh!

go-to-k commented Mar 8, 2024 •

edited

Loading

Uh oh!

mergify bot commented Mar 8, 2024

Uh oh!

aws-cdk-automation commented Mar 8, 2024

Uh oh!

mergify bot commented Mar 8, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

go-to-k commented Feb 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue # (if applicable)

Reason for this change

Description of changes

Description of how you validated changes

Checklist

Uh oh!

aws-cdk-automation left a comment

Choose a reason for hiding this comment

Uh oh!

go-to-k Feb 17, 2024

Choose a reason for hiding this comment

Uh oh!

jumic left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

go-to-k commented Mar 3, 2024

Uh oh!

jumic left a comment

Choose a reason for hiding this comment

Uh oh!

gracelu0 left a comment

Choose a reason for hiding this comment

Uh oh!

mergify bot commented Mar 7, 2024

Uh oh!

go-to-k commented Mar 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mergify bot commented Mar 8, 2024

Uh oh!

aws-cdk-automation commented Mar 8, 2024

AWS CodeBuild CI Report

Uh oh!

mergify bot commented Mar 8, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

go-to-k commented Feb 17, 2024 •

edited

Loading

go-to-k commented Mar 8, 2024 •

edited

Loading