chore(rds): add clusterArn property to DatabaseCluster#29133
chore(rds): add clusterArn property to DatabaseCluster#29133mergify[bot] merged 2 commits intoaws:mainfrom BenFradet:benfradet/db-cluster-arn
Conversation
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
| readonly engine?: IClusterEngine; | ||
|
|
||
| /** | ||
| * The ARN of the clusteDatabaseClusterr |
There was a problem hiding this comment.
Nit: looks like the spelling got a little messed up here -- how about just "The ARN of the database cluster"?
There was a problem hiding this comment.
sorry, don't know how that got there 😅
colifran
left a comment
There was a problem hiding this comment.
Looks good! Just one small comment.
Pull request has been modified.
|
Hello Team, |
|
@colifran any update on this issue. can cx try anything from their end to resolve this issue |
|
@affanc It seems like you're saying this same functionality should be replicated on the construct you linked? If that's the case, they should open an issue or they can create a PR to add the functionality they need. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Issue # (if applicable)
Reason for this change
This is to bring parity with #10741, we need the cluster arn to enable data api manually waiting for #28574.
Description of changes
This adds a clusterArn property to IDatabaseCluster
Description of how you validated changes
The changes have been validated through a unit test
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license