Skip to content

chore(test PR build validation)#28918

Closed
comcalvi wants to merge 14 commits intomainfrom
comcalvi/changeset-nested-stacks
Closed

chore(test PR build validation)#28918
comcalvi wants to merge 14 commits intomainfrom
comcalvi/changeset-nested-stacks

Conversation

@comcalvi
Copy link
Copy Markdown
Contributor

@comcalvi comcalvi commented Jan 29, 2024 •
edited
Loading

opening to see if PR validations work yet. (Don't merge this).

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Jan 29, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team January 29, 2024 20:04
@comcalvi comcalvi self-assigned this Jan 29, 2024
@comcalvi comcalvi added the pr/do-not-merge This PR should not be merged at this time. label Jan 29, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 29, 2024
aws-cdk-automation
aws-cdk-automation requested changes Jan 29, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation added the pr/needs-cli-test-run This PR needs CLI tests run against it. label Jan 29, 2024
@github-actions github-actions bot mentioned this pull request Feb 1, 2024
Closed
@kaizencc kaizencc closed this Feb 2, 2024
@comcalvi comcalvi reopened this Feb 6, 2024
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Feb 6, 2024

The pull request linter fails with the following errors:

❌ The title of this pull request does not follow the Conventional Commits format, see https://www.conventionalcommits.org/.
❌ CLI code has changed. A maintainer must run the code through the testing pipeline (git fetch origin pull/28918/head && git push -f origin FETCH_HEAD:test-main-pipeline), then add the 'pr-linter/cli-integ-tested' label when the pipeline succeeds.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Feb 6, 2024

➡️ PR build request submitted to test-main-pipeline ⬅️

A maintainer must now check the pipeline and add the pr-linter/cli-integ-tested label once the pipeline succeeds.

@comcalvi comcalvi closed this Feb 6, 2024
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Feb 6, 2024

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: a10a3a6
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aws-cdk-automation aws-cdk-automation aws-cdk-automation requested changes

Assignees

@comcalvi comcalvi

Labels

contribution/core This is a PR that came from AWS. p2 pr/do-not-merge This PR should not be merged at this time. pr/needs-cli-test-run This PR needs CLI tests run against it.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@comcalvi @aws-cdk-automation @kaizencc