fix(apigatewayv2): WebSocketAwsIntegration ignores requestParameters#28859
fix(apigatewayv2): WebSocketAwsIntegration ignores requestParameters#28859
WebSocketAwsIntegration ignores requestParameters#28859Conversation
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
WebSocketAwsIntegration ignores requestParameters
|
@FayezX Thanks for making this fix. I apologize that I missed the property on my last PR. Would be happy to approve once a small unit test is added to silent the linter. |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
| integrationUri: `arn:aws:apigateway:${stack.region}:dynamodb:action/PutItem`, | ||
| integrationMethod: HttpMethod.POST, | ||
| credentialsRole: apiRole, | ||
| requestParameters: { |
There was a problem hiding this comment.
@FayezX This won't be enough unfortunately, you'll need to build this change and run yarn integ <path-to-this-file> --update-on-failed to update the snapshots as well.
There was a problem hiding this comment.
Hey Gavin, I think i will need assistance on this. Unfortunately I don't know this library very well. Can you help out please?
There was a problem hiding this comment.
npx lerna run build --scope=@aws-cdk-testing/framework-integ
cd packages/@aws-cdk-testing/framework-integ
yarn integ test/aws-apigatewayv2-integrations/test/websocket/integ.aws.js --update-on-failed
There was a problem hiding this comment.
I am having some typescript compilation issues and the commands fail for me. Please feel free to add to the pr as you see fit.
There was a problem hiding this comment.
It seems that the command itself is not working. Try yarn integ --update-on-failed instead and it should work for you.
There was a problem hiding this comment.
running the command yarn integ --update-on-failed gives me yarn integ --update-on-failed Error: Cannot find module './integ-runner.js'. The command seems to be trying to run /packages/@aws-cdk/integ-runner/bin/integ-runner but cannot find the ./integ-runner.js file and fails.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Pull request has been modified.
|
Looks like there is another Pr which fixes this. Please take a look here #28905 |
#28718 missed adding
requestParametersto theWebSocketAwsIntegration.