chore(framework-integ): ELBv2 OIDC test disregards DOMAIN_NAME for DNS record#28804
chore(framework-integ): ELBv2 OIDC test disregards DOMAIN_NAME for DNS record#28804
Conversation
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
This PR has been in the BUILD FAILING state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
|
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
|
The pull request linter fails with the following errors: PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing |
This test doesn't use the
DOMAIN_NAMEenvironment variable when trying to create the alias record. This results in a DNS resolution failure in the lambda function ifDOMAIN_NAME !== HOSTED_ZONE_NAME.Using the
.suffix at the end ensures that the resource will treat this as the FQDN so we don't have to worry about string splitting or parsing out the subdomain from the hosted zone name.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license