Skip to content

fix(autoscaling): step scaling without adjustment type fails#28794

Closed
go-to-k wants to merge 2 commits intoaws:mainfrom
go-to-k:asg-adjustment-type
Closed

fix(autoscaling): step scaling without adjustment type fails#28794
go-to-k wants to merge 2 commits intoaws:mainfrom
go-to-k:asg-adjustment-type

Conversation

@go-to-k
Copy link
Copy Markdown
Contributor

@go-to-k go-to-k commented Jan 20, 2024 •
edited
Loading

Step Scaling without adjustmentType fails with CFn error You must specify an AdjustmentType for policy type: StepScaling.

  • Reproduction code
const asg = new autoscaling.AutoScalingGroup(stack, 'ASG', {
  vpc,
  instanceType: ec2.InstanceType.of(ec2.InstanceClass.BURSTABLE2, ec2.InstanceSize.MICRO),
  machineImage: new ec2.AmazonLinuxImage({ generation: ec2.AmazonLinuxGeneration.AMAZON_LINUX_2 }),
});

asg.scaleOnMetric('StepScaling', {
  metric: new cloudwatch.Metric({ namespace: 'AWS/EC2', metricName: 'CPUUtilization', dimensionsMap: { AutoScalingGroupName: asg.autoScalingGroupName } }),
  scalingSteps: [
    { upper: 10, change: -1 },
    { lower: 50, change: +1 },
    { lower: 90, change: +2 },
  ],
  evaluationPeriods: 10,
  datapointsToAlarm: 5,
  metricAggregationType: autoscaling.MetricAggregationType.MAXIMUM,

  // adjustmentType: autoscaling.AdjustmentType.CHANGE_IN_CAPACITY,
});

According to the CDK code, CHANGE_IN_CAPACITY will be used if adjustmentType is not specified in the prop. But the variable is not passed into StepScalingAction construct (instead props.adjustmentType is passed as is).

So we should use adjustmentType instead of props.adjustmentType.

    const adjustmentType = props.adjustmentType || AdjustmentType.CHANGE_IN_CAPACITY;
    const changesAreAbsolute = adjustmentType === AdjustmentType.EXACT_CAPACITY;
    // ...
    // ...

      this.lowerAction = new StepScalingAction(this, 'LowerPolicy', {
        // adjustmentType: props.adjustmentType,
        adjustmentType,

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team January 20, 2024 14:53
@github-actions github-actions bot added distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2 labels Jan 20, 2024
aws-cdk-automation
aws-cdk-automation requested changes Jan 20, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@go-to-k
Copy link
Copy Markdown
Contributor Author

go-to-k commented Jan 20, 2024

Exemption Request: This PR could cover this bug by unit tests.

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Jan 20, 2024
go-to-k
go-to-k commented Jan 20, 2024
View reviewed changes
packages/aws-cdk-lib/aws-autoscaling/lib/step-scaling-policy.ts

this.lowerAction = new StepScalingAction(this, 'LowerPolicy', {
adjustmentType: props.adjustmentType,
adjustmentType,
Copy link
Copy Markdown
Contributor Author

@go-to-k go-to-k Jan 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The property is defined here.

@go-to-k go-to-k changed the title fix(autoscaling): step scaling without adjustmentType fails fix(autoscaling): step scaling without adjustment type fails Jan 20, 2024
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jan 20, 2024
@github-actions github-actions bot mentioned this pull request Feb 1, 2024
Closed
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Feb 11, 2024

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@go-to-k
Copy link
Copy Markdown
Contributor Author

go-to-k commented Feb 11, 2024

Exemption Request: #28794 (comment)

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Feb 11, 2024

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 5392611
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Feb 19, 2024

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@aws-cdk-automation aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Feb 19, 2024
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Feb 19, 2024

The pull request linter fails with the following errors:

❌ Fixes must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

✅ A exemption request has been requested. Please wait for a maintainer's review.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 19, 2024

⚠️ The sha of the head commit of this PR conflicts with #29158. Mergify cannot evaluate rules on this PR. ⚠️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aws-cdk-automation aws-cdk-automation aws-cdk-automation requested changes

Assignees

No one assigned

Labels

closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@go-to-k @aws-cdk-automation