chore(route53): typo in route53:useCertificate flag#28755
Closed
chore(route53): typo in route53:useCertificate flag#28755
Conversation
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
kaizencc
requested changes
Jan 18, 2024
Contributor
kaizencc
left a comment
There was a problem hiding this comment.
@juanludlf unfortunately we cannot do this without breaking current users of the typo'd feature flag. Best we can do is create a second feature flag with the correct name, but I don't know if that's worth it at this point
Contributor
|
Closing because the suggestion in this PR cannot be accepted unfortunately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed this while reading the docs: https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_route53_patterns-readme.html.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license