feat(iot-actions-alpha): open search action in IoT topic rule#28748
Merged
mergify[bot] merged 8 commits intomainfrom Jan 23, 2024
Merged
feat(iot-actions-alpha): open search action in IoT topic rule#28748mergify[bot] merged 8 commits intomainfrom
mergify[bot] merged 8 commits intomainfrom
Conversation
paulhcsun
suggested changes
Jan 19, 2024
Contributor
paulhcsun
left a comment
There was a problem hiding this comment.
Looks good to me, just some minor grammar fixes.
packages/@aws-cdk/aws-iot-actions-alpha/lib/open-search-action.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-iot-actions-alpha/test/opensearch/integ.open-search-action.ts
Outdated
Show resolved
Hide resolved
Member
Author
|
Thanks for the detailed review! |
aaythapa
reviewed
Jan 22, 2024
paulhcsun
approved these changes
Jan 23, 2024
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CDK has no support to writes data to an Amazon OpenSearch Service via AWS IoT Rule. Adding the action that writes data to an Amazon OpenSearch Service to AWS IoT topic rule.
OpenSearch action for IoT Topic Rule documentation is here: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-iot-topicrule-opensearchaction.html.
Closes #17702.
Tested by deploying my own stack and confirmed that publishing a message to IoT topic rule will successfully write data to open search service.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license