feat(ecs): L2 for ebs task attach#28691
Merged
mergify[bot] merged 12 commits intoaws:mainfrom Jan 17, 2024
Merged
Conversation
c8cd6df to
46e2284
Compare
Contributor
|
@KollaAdithya is changing the fileSystemType prop to be an |
Contributor
|
@go-to-k I put the wrong link in the last PR comment, sorry. Give this one a look. |
Co-authored-by: go-to-k <24818752+go-to-k@users.noreply.github.com>
go-to-k
suggested changes
Jan 12, 2024
Contributor
go-to-k
left a comment
There was a problem hiding this comment.
I commented on a few things. If I find something else later, I may comment on it.
packages/aws-cdk-lib/aws-ecs/lib/base/service-managed-volume.ts
Outdated
Show resolved
Hide resolved
packages/aws-cdk-lib/aws-ecs/lib/base/service-managed-volume.ts
Outdated
Show resolved
Hide resolved
packages/aws-cdk-lib/aws-ecs/lib/base/service-managed-volume.ts
Outdated
Show resolved
Hide resolved
packages/aws-cdk-lib/aws-ecs/lib/base/service-managed-volume.ts
Outdated
Show resolved
Hide resolved
go-to-k
suggested changes
Jan 12, 2024
add validations Co-authored-by: go-to-k <24818752+go-to-k@users.noreply.github.com>
go-to-k
suggested changes
Jan 14, 2024
Contributor
go-to-k
left a comment
There was a problem hiding this comment.
Thanks for the changing!
I've added a few more comments that I hope you'll take a look at.
packages/aws-cdk-lib/aws-ecs/lib/base/service-managed-volume.ts
Outdated
Show resolved
Hide resolved
packages/aws-cdk-lib/aws-ecs/lib/base/service-managed-volume.ts
Outdated
Show resolved
Hide resolved
packages/aws-cdk-lib/aws-ecs/lib/base/service-managed-volume.ts
Outdated
Show resolved
Hide resolved
packages/aws-cdk-lib/aws-ecs/lib/base/service-managed-volume.ts
Outdated
Show resolved
Hide resolved
packages/aws-cdk-lib/aws-ecs/lib/base/service-managed-volume.ts
Outdated
Show resolved
Hide resolved
packages/aws-cdk-lib/aws-ecs/lib/base/service-managed-volume.ts
Outdated
Show resolved
Hide resolved
packages/aws-cdk-lib/aws-ecs/lib/base/service-managed-volume.ts
Outdated
Show resolved
Hide resolved
packages/aws-cdk-lib/aws-ecs/lib/base/service-managed-volume.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: go-to-k <24818752+go-to-k@users.noreply.github.com>
Co-authored-by: go-to-k <24818752+go-to-k@users.noreply.github.com>
go-to-k
suggested changes
Jan 15, 2024
packages/aws-cdk-lib/aws-ecs/lib/base/service-managed-volume.ts
Outdated
Show resolved
Hide resolved
packages/aws-cdk-lib/aws-ecs/lib/base/service-managed-volume.ts
Outdated
Show resolved
Hide resolved
packages/aws-cdk-lib/aws-ecs/lib/base/service-managed-volume.ts
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@MrArnoldPalmer and @go-to-k All the feedback is addressed. Can you take a look and approve it |
go-to-k
approved these changes
Jan 15, 2024
Contributor
go-to-k
left a comment
There was a problem hiding this comment.
Great, thanks @KollaAdithya .
I approve this.
Pull request has been modified.
MrArnoldPalmer
approved these changes
Jan 17, 2024
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This was referenced Feb 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To simplify ECS customer experience, customers need the ability to utilize highly available (HA) durable, high-performance, cost effective block storage for their workloads. To address these needs, ECS will provide support for Elastic Block Storage (EBS) task attachments.
This PR adds the L2 constructs for EBS task attach.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license