feat(rds): Add log group property to RDS instance and RDS cluster#28676
feat(rds): Add log group property to RDS instance and RDS cluster#28676mergify[bot] merged 5 commits intomainfrom
Conversation
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
367fd3f to
8e090c5
Compare
8e090c5 to
7375086
Compare
paulhcsun
left a comment
There was a problem hiding this comment.
Just a few minor doc changes. Should we also create an integ test for RDS cluster?
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
There isn't an easy way to get the new created log group of an DatabaseInstance if the DatabaseInstance has the cloudwatchLogsExport property set. Right now users would have to manual figure out the log group name by constructing
/aws/rds/instance/${this.databaseInstance.instanceIdentifier}/postgresql. Same applies to RDS cluster resource.This is also dangerous as it relies on the naming convention unmodified. It would break the application if the naming convention was somehow changed.
Add a new property
cloudwatchLogGroupsto RDS instance and cluster.Closes ##20358.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license