Skip to content

feat(rds): Adds support for DB2 instance creation#28608

Closed
cedricmillet wants to merge 2 commits intoaws:mainfrom
cedricmillet:feat-#28485
Closed

feat(rds): Adds support for DB2 instance creation#28608
cedricmillet wants to merge 2 commits intoaws:mainfrom
cedricmillet:feat-#28485

Conversation

@cedricmillet
Copy link
Copy Markdown

@cedricmillet cedricmillet commented Jan 7, 2024 •
edited
Loading

The purpose of this issue is to update DatabaseInstance (+ DatabaseInstanceEngine and related classes/interfaces) and add support for RDS with DB2.

Currently 2 versions are handled :
db2-se-11-5 = DB2 Standard Edition v11.5
db2-ae-11.5 = DB2 Advanced Edition v11.5

Closes #28485.

AWS RDS for DB2 official home page

From now, you can create a new RDS for DB2 instance with DatabaseInstance constructor as follow

  // Create a param group intended to store IBM DB2 license
  const pGroup = new ParameterGroup(stack, `MyParamGroup`, {
    engine: DatabaseInstanceEngine.db2Se({ version: Db2EngineVersion.VER_11_5 }),
  })
  pGroup.addParameter("rds.ibm_customer_id", "XXXXXXXXX");
  pGroup.addParameter("rds.ibm_site_id", "XXXXXXXXXXX");
  
  // force cloud formation param group generation:
  // https://github.com/aws/aws-cdk/issues/9741
  pGroup.bindToInstance({}); 

  new DatabaseInstance(stack, `MyDBInstance`, {
    vpc,
    engine: DatabaseInstanceEngine.db2Se({version: Db2EngineVersion.VER_11_5}),
    instanceType: InstanceType.of(InstanceClass.M6I, InstanceSize.LARGE), // Minimal instance class for DB2
    securityGroups: [securityGroup],
    vpcSubnets: { subnetType: SubnetType.PRIVATE_ISOLATED },
    port: 50000,
    databaseName: dbName,
    licenseModel: LicenseModel.BRING_YOUR_OWN_LICENSE,
    parameterGroup: pGroup,
    // + username, storage, storageEncrypted...
  });

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Jan 7, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team January 7, 2024 19:03
@github-actions github-actions bot added effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 labels Jan 7, 2024
aws-cdk-automation
aws-cdk-automation requested changes Jan 7, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Jan 7, 2024

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 79d9351
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@cedricmillet cedricmillet mentioned this pull request Jan 7, 2024
Open
2 tasks
laurelmay
laurelmay reviewed Jan 15, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@laurelmay laurelmay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this! There are a few things that will be helpful to get started with a meaningful review:

  1. Integration tests will be important to ensure that the code here actual creates a working CloudFormation template. https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md has some information and you may find other integration tests in packages/@aws-cdk-testing/framework-integ/test/aws-rds/test to be helpful in seeing how these tests are done for other RDS instance types.
  2. The build needs to be passing. It looks like the primary failure at the moment is because the PR happened to be opened while the build was in a bad state due to date changing at the new year; updating your branch from main should help resolve that failure to see if there are any other issues with the build.

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Jan 29, 2024

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@github-actions github-actions bot mentioned this pull request Feb 1, 2024
Closed
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Feb 6, 2024

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@aws-cdk-automation aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Feb 6, 2024
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Feb 6, 2024

The pull request linter fails with the following errors:

❌ Features must contain a change to a README file.
❌ Features must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aws-cdk-automation aws-cdk-automation aws-cdk-automation requested changes

+1 more reviewer

@laurelmay laurelmay laurelmay left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

(rds): Add support for DB2 in Amazon RDS

3 participants

@cedricmillet @aws-cdk-automation @laurelmay