feat(certificatemanager): add support for additional key algorithms#28603
Closed
feat(certificatemanager): add support for additional key algorithms#28603
Conversation
aws-cdk-automation
previously requested changes
Jan 7, 2024
Collaborator
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
This adds support for any key algorithms that are supported for a certificate request. There are additional supported values; however, they are not supported for new keys only for imported keys.
faa6902 to
c1307bf
Compare
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
laurelmay
commented
Jan 7, 2024
lpizzinidev
suggested changes
Jan 7, 2024
Contributor
lpizzinidev
left a comment
There was a problem hiding this comment.
Looks good 👍
I left some notes for documentation adjustments.
Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>
Contributor
Author
|
Closing in favor of #28597. |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for any key algorithms that are supported for a
certificate request. There are additional supported values; however,
they are not supported for new keys only for imported keys.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license