Skip to content

fix(rds): Failed to create a Database Instance with Kerberos authentication configured#28601

Merged
mergify[bot] merged 6 commits intoaws:mainfrom
badmintoncryer:28600-fixKerberosIntegration
Jan 23, 2024
Merged

fix(rds): Failed to create a Database Instance with Kerberos authentication configured#28601
mergify[bot] merged 6 commits intoaws:mainfrom
badmintoncryer:28600-fixKerberosIntegration

Conversation

@badmintoncryer
Copy link
Copy Markdown
Contributor

@badmintoncryer badmintoncryer commented Jan 6, 2024 •
edited
Loading

This PR resolves an issue where deploying an RDS instance configured with Kerberos authentication fails.
When domainRole is undefined, CDK creates a default IAM role. However, this role lacks the necessary principals, leading to deployment failure. To resolve this, the necessary principals have been added to the role.

-        assumedBy: new iam.ServicePrincipal('rds.amazonaws.com'),
+        assumedBy: new iam.CompositePrincipal(
+          new iam.ServicePrincipal('rds.amazonaws.com'),
+          new iam.ServicePrincipal('directoryservice.rds.amazonaws.com'),
+        ),

Closes #28600.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added bug This issue is a bug. p2 valued-contributor [Pilot] contributed between 6-12 PRs to the CDK labels Jan 6, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team January 6, 2024 19:17
aws-cdk-automation
aws-cdk-automation previously requested changes Jan 6, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation dismissed their stale review January 6, 2024 20:40

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@badmintoncryer badmintoncryer mentioned this pull request Jan 9, 2024
Closed
@badmintoncryer badmintoncryer force-pushed the 28600-fixKerberosIntegration branch from cdb113d to 89d2870 Compare January 17, 2024 14:32
@badmintoncryer badmintoncryer marked this pull request as ready for review January 17, 2024 14:45
@github-actions github-actions bot added the effort/medium Medium work item – several days of effort label Jan 17, 2024
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jan 17, 2024
go-to-k
go-to-k approved these changes Jan 21, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@go-to-k go-to-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Jan 21, 2024
@badmintoncryer
Copy link
Copy Markdown
Contributor Author

badmintoncryer commented Jan 21, 2024

@go-to-k Thanks!

GavinZZ
GavinZZ approved these changes Jan 23, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@GavinZZ GavinZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Thanks for addressing this issue!

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jan 23, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jan 23, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jan 23, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Jan 23, 2024

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 9fe162e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit b620f1b into aws:main Jan 23, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jan 23, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@badmintoncryer badmintoncryer deleted the 28600-fixKerberosIntegration branch January 23, 2024 20:47
@github-actions github-actions bot mentioned this pull request Feb 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

+2 more reviewers

@go-to-k go-to-k go-to-k approved these changes

@GavinZZ GavinZZ GavinZZ approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug This issue is a bug. effort/medium Medium work item – several days of effort p2 valued-contributor [Pilot] contributed between 6-12 PRs to the CDK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

rds: Failed to create a Database Instance with Kerberos authentication configured

4 participants

@badmintoncryer @aws-cdk-automation @go-to-k @GavinZZ