Skip to content

chore(autoscaling): add lowest-price OnDemandAllocationStrategy enum to aws-autoscaling#28396

Merged
mergify[bot] merged 3 commits intoaws:mainfrom
bwagner5:od-lowest-price
Dec 18, 2023
Merged

chore(autoscaling): add lowest-price OnDemandAllocationStrategy enum to aws-autoscaling#28396
mergify[bot] merged 3 commits intoaws:mainfrom
bwagner5:od-lowest-price

Conversation

@bwagner5
Copy link
Copy Markdown
Contributor

Closes #28395

Adds the On-Demand lowest-price allocation strategy enum for aws-autoscaling.

https://docs.aws.amazon.com/autoscaling/ec2/userguide/allocation-strategies.html#on-demand-allocation-strategy


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team December 16, 2023 16:33
@github-actions github-actions bot added bug This issue is a bug. p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Dec 16, 2023
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@bwagner5 bwagner5 changed the title feat: add lowest-price OnDemandAllocationStrategy enum to aws-autoscaling chore(autoscaling): add lowest-price OnDemandAllocationStrategy enum to aws-autoscaling Dec 16, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review December 16, 2023 16:41

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Dec 16, 2023
Copy link
Copy Markdown
Contributor

@paulhcsun paulhcsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks for adding this!

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 5801a0d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Dec 18, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Dec 18, 2023
@mergify mergify bot merged commit 7a721d3 into aws:main Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

aws-autoscaling: OnDemandAllocationStrategy enum does not support lowest-price

3 participants