feat(ses): add scalingMode property to dedicated ip pool#28392
feat(ses): add scalingMode property to dedicated ip pool#28392mergify[bot] merged 12 commits intoaws:mainfrom
Conversation
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
ebdd76c to
ab5c377
Compare
lpizzinidev
left a comment
There was a problem hiding this comment.
Thanks for the contribution 👍
I left some notes for minor adjustments.
| // new ses.DedicatedIpPool(stack, 'Pool', { | ||
| // dedicatedIpPoolName: 'myPool', | ||
| // scalingMode: ses.ScalingMode.MANAGED, | ||
| // }); | ||
|
|
||
| new ses.DedicatedIpPool(stack, 'Pool', {}); |
There was a problem hiding this comment.
| // new ses.DedicatedIpPool(stack, 'Pool', { | |
| // dedicatedIpPoolName: 'myPool', | |
| // scalingMode: ses.ScalingMode.MANAGED, | |
| // }); | |
| new ses.DedicatedIpPool(stack, 'Pool', {}); | |
| new ses.DedicatedIpPool(stack, 'Pool', { | |
| dedicatedIpPoolName: 'myPool', | |
| scalingMode: ses.ScalingMode.MANAGED, | |
| }); |
Incomplete integration test.
There was a problem hiding this comment.
Thank you for your review!
I conducted the integration test again after making the modifications.
Atfirst, I tried conducting an integration test, but failed to create an IP pool. It seems that the 'poolName' must be within 64 characters and only allow lowercase letters, numbers, periods, dashes and underscores. (Deployment fails because 'myPool' includes uppercase letters.)
I have added the above conditions to the description of 'dedicatedIpPoolName', but is it okay to include such a modification in this Pull Request?
2479f5c to
247a148
Compare
Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>
Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>
Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>
Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>
|
@lpizzinidev |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Pull request has been modified.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Closes #27418
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license