docs(lambda): clarify FunctionOptions.allowAllOutbound property#28367
Merged
mergify[bot] merged 5 commits intoaws:mainfrom Dec 15, 2023
Merged
docs(lambda): clarify FunctionOptions.allowAllOutbound property#28367mergify[bot] merged 5 commits intoaws:mainfrom
mergify[bot] merged 5 commits intoaws:mainfrom
Conversation
…add-docs-for-allowAllOutbound
scanlonp
previously requested changes
Dec 14, 2023
Contributor
scanlonp
left a comment
There was a problem hiding this comment.
Can we add a guidance sentence? Maybe "Instead configure 'allowAllOutbound' directly on the security group".
But good addition!
kaizencc
reviewed
Dec 14, 2023
Pull request has been modified.
kaizencc
approved these changes
Dec 14, 2023
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following PR adds validation for the case when
allowAllOutboundandsecurityGroupsare specified at the same time inFunctionOptions.#26528
(#27157)
According to related issues and discussions, this PR causes existing Lambda deployments to fail.
However, since this change has already been merged and I think it is the correct change, I did not fix the validation process but added documentation to clarify the behavior.
Relates to #28170, #27669
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license