Skip to content

fix(apigatewayv2-integrations): integrations of imported lambda functions do not get configured#27861

Merged
mergify[bot] merged 15 commits intomainfrom
sumughan/apigwv2-fix-subroutes-integration
Nov 20, 2023
Merged

fix(apigatewayv2-integrations): integrations of imported lambda functions do not get configured#27861
mergify[bot] merged 15 commits intomainfrom
sumughan/apigwv2-fix-subroutes-integration

Conversation

@sumupitchayan
Copy link
Copy Markdown
Contributor

@sumupitchayan sumupitchayan commented Nov 6, 2023 •
edited
Loading

Closes #18965

HTTPLambdaIntegration using imported lambda functions are currently not being configured. This is due to the fact that the canCreatePermissions property is set to false in imported lambdas, so the lambda permissions are never created.

This PR fixes this issue by:

  • Setting the sameEnvironment property to true for lambdas imported using fromFunctionName()
  • Adding clarification in documentation about imported lambdas needing to belong to the same stack account and region as that of the lambda being imported from be able to add permissions
  • Adding a new warning to be thrown when the addPermissions() function is called on a lambda with canCreatePermissions set to false.

The new integ test file tests that imported lambdas using fromFunctionName() and fromFunctionAttributes() (with sameEnvironment set to true) work as expected, including on sub-route integrations.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@sumupitchayan
completed integ test case with assertions, referenced lambdas are not…
7ce2854 
… configured

Signed-off-by: Sumu <sumughan@amazon.com>
@sumupitchayan sumupitchayan changed the title fix(apigatewayv2-integrations): integrations of referenced lambda function do not get configured fix(apigatewayv2-integrations): integrations of referenced lambda functions do not get configured Nov 6, 2023
@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p1 labels Nov 6, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team November 6, 2023 20:36
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 6, 2023
aws-cdk-automation
aws-cdk-automation previously requested changes Nov 6, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@sumupitchayan
integ test file cleanup
3b96f04 
Signed-off-by: Sumu <sumughan@amazon.com>
@sumupitchayan
integ tests with first 2 lambda function assertions passing
ffab230 
Signed-off-by: Sumu <sumughan@amazon.com>
@sumupitchayan
add third route to integ test, currently failing without change to la…
c60bd9c 
…mbda

Signed-off-by: Sumu <sumughan@amazon.com>
@sumupitchayan
update lambda readme, function code comments, and set sameEnvironment…
9b8a74c 
… to true in fromFunctionName()

Signed-off-by: Sumu <sumughan@amazon.com>
@sumupitchayan
add functionName prop to thirdlambda function
2c962f3 
Signed-off-by: Sumu <sumughan@amazon.com>
@sumupitchayan
add snapshots
f5455fd 
Signed-off-by: Sumu <sumughan@amazon.com>
@sumupitchayan sumupitchayan changed the title fix(apigatewayv2-integrations): integrations of referenced lambda functions do not get configured fix(apigatewayv2-integrations): integrations of imported lambda functions do not get configured Nov 10, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review November 10, 2023 18:33

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@sumupitchayan sumupitchayan marked this pull request as ready for review November 10, 2023 20:20
@sumupitchayan
cleanup doc comments
0a8739a 
Signed-off-by: Sumu <sumughan@amazon.com>
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 13, 2023
rix0rrr
rix0rrr reviewed Nov 14, 2023
View reviewed changes
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 20, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 20, 2023
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Nov 20, 2023

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: c6d87e5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 2c21ea0 into main Nov 20, 2023
@mergify mergify bot deleted the sumughan/apigwv2-fix-subroutes-integration branch November 20, 2023 16:44
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 20, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@sumupitchayan sumupitchayan added effort/medium Medium work item – several days of effort and removed effort/small Small work item – less than a day of effort labels Nov 21, 2023
@github-actions github-actions bot mentioned this pull request Dec 1, 2023
Closed
@enpatrik enpatrik mentioned this pull request Jan 31, 2024
Closed
@sumupitchayan sumupitchayan mentioned this pull request Sep 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rix0rrr rix0rrr rix0rrr approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees

No one assigned

Labels

bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/medium Medium work item – several days of effort p1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

(aws_apigatewayv2.HttpLambdaIntegration): add_routes integration to subroute doesn't take affect

3 participants

@sumupitchayan @aws-cdk-automation @rix0rrr