chore(stepfunctions-tasks): add a doc and an integ test for spot instance fleets in EMR#27809
Merged
mergify[bot] merged 3 commits intoaws:mainfrom Nov 6, 2023
Merged
Conversation
go-to-k
commented
Nov 2, 2023
Comment on lines
+19
to
+24
| launchSpecifications: { | ||
| spotSpecification: { | ||
| allocationStrategy: EmrCreateCluster.SpotAllocationStrategy.CAPACITY_OPTIMIZED, | ||
| timeoutAction: EmrCreateCluster.SpotTimeoutAction.TERMINATE_CLUSTER, | ||
| timeoutDurationMinutes: 60, | ||
| }, |
Contributor
Author
There was a problem hiding this comment.
blockDurationMinutes is not specified, because it is no longer available.
Spot Instances with a defined duration (also known as Spot blocks) are no longer available to new customers from July 1, 2021. For customers who have previously used the feature, we will continue to support Spot Instances with a defined duration until December 31, 2022.
https://docs.aws.amazon.com/emr/latest/APIReference/API_SpotProvisioningSpecification.html
lpizzinidev
suggested changes
Nov 2, 2023
Contributor
lpizzinidev
left a comment
There was a problem hiding this comment.
Nice 👍
Just a small adjustment.
Comment on lines
662
to
667
| * This is no longer available to new customers from July 1, 2021. | ||
| * For customers who have previously used the feature, we will continue to support Spot Instances | ||
| * with a defined duration until December 31, 2022. | ||
| * | ||
| * @default - No blockDurationMinutes | ||
| */ |
Contributor
There was a problem hiding this comment.
Suggested change
| * This is no longer available to new customers from July 1, 2021. | |
| * For customers who have previously used the feature, we will continue to support Spot Instances | |
| * with a defined duration until December 31, 2022. | |
| * | |
| * @default - No blockDurationMinutes | |
| */ | |
| * @default - No blockDurationMinutes | |
| * | |
| * @deprecated - Spot Instances with a defined duration (also known as Spot blocks) are no longer available to new customers from July 1, 2021. | |
| * For customers who have previously used the feature, we will continue to support Spot Instances with a defined duration until December 31, 2022. | |
| */ |
Should be deprecated.
Contributor
Author
There was a problem hiding this comment.
Thanks for the review! I changed it:
lpizzinidev
approved these changes
Nov 2, 2023
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the following points for spot instance fleet in EMR.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license