Skip to content

chore(cdk): remove mockery#27242

Merged
mergify[bot] merged 2 commits intomainfrom
mrgrain/chore/remove-mockery
Sep 21, 2023
Merged

chore(cdk): remove mockery#27242
mergify[bot] merged 2 commits intomainfrom
mrgrain/chore/remove-mockery

Conversation

@mrgrain
Copy link
Copy Markdown
Contributor

@mrgrain mrgrain commented Sep 21, 2023

Replace usage of mockery in some tests with a more modern way.

Closes https://github.com/aws/aws-cdk/security/dependabot/181


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Sep 21, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team September 21, 2023 20:10
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Sep 21, 2023
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@mrgrain mrgrain force-pushed the mrgrain/chore/remove-mockery branch from ffbda06 to 3c9708e Compare September 21, 2023 20:24
"constructs": "^10.0.0",
"fast-check": "^3.13.0",
"jest": "^29.7.0",
"jest-mock": "^29.7.0",
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note, this is already installed with jest anyway. Just needs be explicit now, since we are importing a utility function from it.

@mrgrain mrgrain changed the title chore(aws-cdk): remove mockery chore(cdk): remove mockery Sep 21, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review September 21, 2023 20:32

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 21, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 53b89a4
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 54537c5 into main Sep 21, 2023
@mergify mergify bot deleted the mrgrain/chore/remove-mockery branch September 21, 2023 21:13
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 21, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants