Skip to content

docs(autoscaling): use latestAmazonLinux2() instead of latestAmazonLinux() due to deprecation#27230

Merged
mergify[bot] merged 3 commits intoaws:mainfrom
tam0ri:docs/autoscaling-latest-amazon-linux
Sep 21, 2023
Merged

docs(autoscaling): use latestAmazonLinux2() instead of latestAmazonLinux() due to deprecation#27230
mergify[bot] merged 3 commits intoaws:mainfrom
tam0ri:docs/autoscaling-latest-amazon-linux

Conversation

@tam0ri
Copy link
Copy Markdown
Contributor

@tam0ri tam0ri commented Sep 21, 2023

Currently, the following document regarding AutoScalingGroup uses ec2.MachineImage.latestAmazonLinux() method as examples.
https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_autoscaling-readme.html

However, this method has been already deprecated as below.
https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_ec2.MachineImage.html#static-latestwbramazonwbrlinuxpropsspan-classapi-icon-api-icon-deprecated-titlethis-api-element-is-deprecated-its-use-is-not-recommended%EF%B8%8Fspan

⚠️ Deprecated: use MachineImage.latestAmazonLinux2 instead

This PR solves the issue by replacing this method with latestAmazonLinux2().

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Sep 21, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team September 21, 2023 00:27
@github-actions github-actions bot added the admired-contributor [Pilot] contributed between 13-24 PRs to the CDK label Sep 21, 2023
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Sep 21, 2023
lpizzinidev
lpizzinidev approved these changes Sep 21, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@lpizzinidev lpizzinidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 👍

@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Sep 21, 2023
mrgrain
mrgrain previously approved these changes Sep 21, 2023
View reviewed changes
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 21, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Sep 21, 2023
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 21, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed mrgrain’s stale review September 21, 2023 13:35

Pull request has been modified.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 21, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Sep 21, 2023

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: a9fb983
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit b881b82 into aws:main Sep 21, 2023
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 21, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@github-actions github-actions bot mentioned this pull request Oct 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kaizencc kaizencc kaizencc approved these changes

@mrgrain mrgrain mrgrain left review comments

+1 more reviewer

@lpizzinidev lpizzinidev lpizzinidev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

admired-contributor [Pilot] contributed between 13-24 PRs to the CDK p2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tam0ri @aws-cdk-automation @mrgrain @lpizzinidev @kaizencc