chore: update cdk migrate command to allow for stack name input and additional languages#27134
Conversation
…dditional languages This change updates use of noctilucent to cdk-from-cfn and installs it from npm. It also adds some additional language support and stack renaming.
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
4d98d72 to
619f018
Compare
|
Adding the do-not-merge so that this doesn't get approved before I'm ready for it to merge. Using this PR to run the integ tests against my changes. |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
This PR is now ready to go. |
| } | ||
|
|
||
| export async function initializeProject(template: InitTemplate, language: string, canUseNetwork: boolean, generateOnly: boolean, workDir: string) { | ||
| async function initializeProject( |
There was a problem hiding this comment.
non binding comment: a lot of these functions have a ton of props, and given that its experimental why not change it so that it takes in a property bag initializeProjectOptions so that we can easily add properties to it in the future
There was a problem hiding this comment.
Good call out! I'll make this change in a future PR.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
➡️ PR build request submitted to A maintainer must now check the pipeline and add the |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This change updates use of noctilucent to cdk-from-cfn and installs it from npm. It also adds some additional language support and stack renaming.
Not included in this PR:
migratefile.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license