fix(lambda): update default runtimes and tests to node 16 everywhere#26921
fix(lambda): update default runtimes and tests to node 16 everywhere#26921mergify[bot] merged 25 commits intomainfrom
Conversation
c32ec99 to
c8799ed
Compare
| // the X509 certificate API is available only in node16. | ||
| // since we compile the repo against node 14, typechecking it will fail. | ||
| // its currently too complex to configure node16 only on this | ||
| // file (jsii doesn't support custom tsconfig) | ||
| // so we disable typechecking. don't worry, we have sufficient integ tests that | ||
| // validate this code doesn't break. | ||
| // @ts-nocheck |
There was a problem hiding this comment.
New jsii version works with node16
There was a problem hiding this comment.
This file has non test changes
There was a problem hiding this comment.
This file has non test changes
There was a problem hiding this comment.
This file has non test changes
There was a problem hiding this comment.
This file has non test changes
There was a problem hiding this comment.
This file has non test changes
There was a problem hiding this comment.
This file has non test changes
c8799ed to
e25dc92
Compare
| exclude: ['*.ts'], | ||
| }), | ||
| runtime: lambda.Runtime.NODEJS_14_X, | ||
| runtime: lambda.Runtime.NODEJS_16_X, |
There was a problem hiding this comment.
Only to node16 because it is still using SDKv2
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Attempted a fix, but that deployment takes ages.
…re expired so don't work even when restored
…ns provider. S3 body is not treated as a buffer
|
➡️ PR build request submitted to A maintainer must now check the pipeline and add the |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Upgrades a few runtime versions from
NODEJS_14_X(which is EOL and will enter Deprecation Phase 1 on Nov 27, 2023) toNODEJS_16_X.Also updates all the tests.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license