fix(route53): IHostedZone cannot be used for ses.Identity.publicHostedZone anymore#26888
Merged
mergify[bot] merged 2 commits intoaws:mainfrom Aug 25, 2023
Merged
fix(route53): IHostedZone cannot be used for ses.Identity.publicHostedZone anymore#26888mergify[bot] merged 2 commits intoaws:mainfrom
mergify[bot] merged 2 commits intoaws:mainfrom
Conversation
rix0rrr
approved these changes
Aug 25, 2023
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Identity.publicHostedZonetakes anIPublicHostedZone, but because of TypeScript structural typing it would also accept anIHostedZone.When in this PR the
grantDelegationmethod was added to theIPublicHostedZoneinterface, this passing was no longer allowed and code that used to work on accident, no longer works.For example:
It raises an error because the imported
zonedoes not implement thegrantDelegationmethod.This fix moves the
grantDelegationmethod declaration into theIHostedZoneinterface and makes it available to all imported zones.Closes #26872.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license