fix(sqs): encryptionType is incorrect when encryptionMasterKey is provided#26886
Conversation
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
|
|
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
In #19796 we added additional validation to sns subscription.
For that purpose the Queue
encryptionTypewas exposed as a public property.However the PR forgot to take into account that the provided
encryptionproperty is automatically changed when aencryptionMasterKeyis provided.This PR ensures that the public
encryptionTypehas the correct value.Additionally, adds a warning for an incorrect configuration scenario where
encryptionMasterKeyis provided together with anencryptionother than QueueEncryption.KMS.This feature was supposed to allow users to simply provide an encryption key and have the encryption type being selected automatically.
However it now unintentionally allows for wrong configurations that are silently fixed, e.g. setting QueueEncryption.UNENCRYPTED and providing an encryption key.
The warning keeps backwards compatibility, but instructs users to fix their configuration.
Closes #26719
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license