Skip to content

docs(stepfunctions): multi-state example for map state#26870

Merged
mergify[bot] merged 2 commits intoaws:mainfrom
anshikam:anshikam/26707
Aug 25, 2023
Merged

docs(stepfunctions): multi-state example for map state#26870
mergify[bot] merged 2 commits intoaws:mainfrom
anshikam:anshikam/26707

Conversation

@anshikam
Copy link
Copy Markdown
Contributor

@anshikam anshikam commented Aug 24, 2023

Closes #26707.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Aug 24, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team August 24, 2023 16:31
@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Aug 24, 2023
Copy link
Copy Markdown
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will help fix the build error. But you can also check locally with yarn rosetta --strict.

When the build succeeds feel free to move this out of draft mode. Thanks for your contribution!

const definition = choice
.when(condition1, step1)
.otherwise(step2)
.afterwards())
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.afterwards())
.afterwards()

Copy link
Copy Markdown
Contributor Author

@anshikam anshikam Aug 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much @kaizencc for feedback.
I am running into JS heap out of memory issue when I run yarn rosetta:extract --strict on GitPod (hence having to publish to this draft PR after I make changes and note the build failures).

Are there any known workarounds? I tried increasing mem size using NODE_OPTIONS="--max-old-space-size=8192 but to no avail

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also posted my query on cdk.dev slack for ref https://cdk-dev.slack.com/archives/C041656G340/p1692825834382109

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure, but it is definitely a memory intensive process that may take more memory than yarn build. Can you create an issue for it? That's probably the best thing to do here. Thanks for your contribution anyway!

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kaizencc for approving, will do!

@kaizencc kaizencc changed the title docs(step-functions): add multi state example for map state docs(stepfunctions): multi-state example for map state Aug 25, 2023
@github-actions github-actions bot added effort/small Small work item – less than a day of effort p1 and removed p2 labels Aug 25, 2023
@kaizencc kaizencc marked this pull request as ready for review August 25, 2023 18:28
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: c959660
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 25, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 803cfe3 into aws:main Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/small Small work item – less than a day of effort p1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

aws-cdk-lib.stepfunctions: Add Non-trivial Examples to Map Documentation

3 participants