Skip to content

refactor(eks): exposed chart, repository, version and chartAsset props for HelmChart construct#26852

Merged
mergify[bot] merged 4 commits intoaws:mainfrom
davidcosc:issue-26678
Aug 23, 2023
Merged

refactor(eks): exposed chart, repository, version and chartAsset props for HelmChart construct#26852
mergify[bot] merged 4 commits intoaws:mainfrom
davidcosc:issue-26678

Conversation

@davidcosc
Copy link
Copy Markdown
Contributor

@davidcosc davidcosc commented Aug 23, 2023

This change was made to improve convenience when working with the HelmChart construct.
For example this allows for simpler creation of aspects for inspecting helm charts as mentioned in #26678 .

Closes #26678.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 labels Aug 23, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team August 23, 2023 11:48
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Aug 23, 2023
lpizzinidev
lpizzinidev reviewed Aug 23, 2023
View reviewed changes
lpizzinidev
lpizzinidev suggested changes Aug 23, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@lpizzinidev lpizzinidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!
Looks good overall to me, I left you a comment for a small change on variable declaration.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Aug 23, 2023
@davidcosc
Copy link
Copy Markdown
Contributor Author

davidcosc commented Aug 23, 2023

Thanks for the fast review! I added another commit matching the type definitions to the ones used by the HelmChartOptions.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Aug 23, 2023
colifran
colifran previously approved these changes Aug 23, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@colifran colifran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidcosc This looks good. Thanks for your contribution!

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 23, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed colifran’s stale review August 23, 2023 23:21

Pull request has been modified.

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Aug 23, 2023

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 35e60ae
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 23, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 9a71e02 into aws:main Aug 23, 2023
@github-actions github-actions bot mentioned this pull request Sep 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@lpizzinidev lpizzinidev lpizzinidev approved these changes

@colifran colifran colifran approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 pr/needs-maintainer-review This PR needs a review from a Core Team Member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

aws-eks: Add properties from IHelmChartOptions to HelmChart construct

4 participants

@davidcosc @aws-cdk-automation @lpizzinidev @colifran