Skip to content

feat(apigateway): set RestApi CloudWatchRole and Account retention policy#26836

Merged
mergify[bot] merged 6 commits intoaws:mainfrom
lpizzinidev:gh-26827
Aug 23, 2023
Merged

feat(apigateway): set RestApi CloudWatchRole and Account retention policy#26836
mergify[bot] merged 6 commits intoaws:mainfrom
lpizzinidev:gh-26827

Conversation

@lpizzinidev
Copy link
Copy Markdown
Contributor

Adds a cloudWatchRoleRemovalPolicy property to RestApiBaseProps that allows to specify a custom retention policy for CloudWatchRole and Account.
Defaults to RemovalPolicy.RETAIN.

Closes #26827.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team August 22, 2023 08:41
@github-actions github-actions bot added star-contributor [Pilot] contributed between 25-49 PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 labels Aug 22, 2023
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Aug 22, 2023
Copy link
Copy Markdown
Contributor

@rix0rrr rix0rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there, but it should be not allowed to pass cloudWatchRoleRemovalPolicy if cloudWatchRole == false.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Aug 22, 2023
@mergify mergify bot dismissed rix0rrr’s stale review August 23, 2023 07:10

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Aug 23, 2023
rix0rrr
rix0rrr previously approved these changes Aug 23, 2023
@rix0rrr rix0rrr changed the title feat(apigateway): new property for setting RestApi CloudWatchRole and Account retention policy feat(apigateway): set RestApi CloudWatchRole and Account retention policy Aug 23, 2023
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Aug 23, 2023
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 23, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed rix0rrr’s stale review August 23, 2023 12:12

Pull request has been modified.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 23, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: afdac07
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 7af20ba into aws:main Aug 23, 2023
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 23, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 star-contributor [Pilot] contributed between 25-49 PRs to the CDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ApiGateway: parameter for changing retention policy of CloudWatchRole and Account

3 participants