fix(core): logical IDs are not allowed to start with digits#26821
fix(core): logical IDs are not allowed to start with digits#26821mergify[bot] merged 4 commits intoaws:mainfrom kirkwat:main
Conversation
|
|
||
| function randomAlphaNumeric() { | ||
| const alphaNumericChars = 'abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789'; | ||
| return alphaNumericChars.charAt(Math.floor(Math.random() * 62)); |
There was a problem hiding this comment.
Better to go with Math.random() * alphaNumericChars.length
| } | ||
| } | ||
|
|
||
| function generateAlphaNumericString(chars: number) { |
There was a problem hiding this comment.
We should use generateAlphaNumericString also here.
lpizzinidev
left a comment
There was a problem hiding this comment.
Thanks for the contribution! 💪
Looks good overall, just a couple of minor changes on the tests should be done in my opinion.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
1 similar comment
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
The resource logical ID validation regex (
VALID_LOGICALID_REGEX) is updated to be consistent with the CloudFormation documentation which says that logical IDs are alphanumeric.Closes #26075.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license