Skip to content

fix(pipelines): default image Ubuntu6 using EOL Node 16, switch to Ubuntu7#26817

Merged
mergify[bot] merged 3 commits intoaws:mainfrom
lpizzinidev:gh-26810
Aug 22, 2023
Merged

fix(pipelines): default image Ubuntu6 using EOL Node 16, switch to Ubuntu7#26817
mergify[bot] merged 3 commits intoaws:mainfrom
lpizzinidev:gh-26810

Conversation

@lpizzinidev
Copy link
Copy Markdown
Contributor

@lpizzinidev lpizzinidev commented Aug 19, 2023

Node 16 is approaching end-of-life (2023-09-11).
This changes the default image version to aws/codebuild/standard:7.0 which uses Node 18.

Closes #26810.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team August 19, 2023 13:16
@github-actions github-actions bot added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 star-contributor [Pilot] contributed between 25-49 PRs to the CDK labels Aug 19, 2023
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Aug 19, 2023
@rix0rrr rix0rrr changed the title chore(pipelines): Node 16 EOL, move to Ubuntu 7 fix(pipelines): default image Ubuntu6 using EOL Node 16, switch to Ubuntu7 Aug 22, 2023
rix0rrr
rix0rrr previously approved these changes Aug 22, 2023
View reviewed changes
aws-cdk-automation
aws-cdk-automation previously requested changes Aug 22, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Aug 22, 2023
@mrgrain mrgrain added pr/do-not-merge This PR should not be merged at this time. pr-linter/exempt-integ-test The PR linter will not require integ test changes and removed pr/do-not-merge This PR should not be merged at this time. labels Aug 22, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review August 22, 2023 12:10

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 22, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed rix0rrr’s stale review August 22, 2023 12:57

Pull request has been modified.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 22, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Aug 22, 2023

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 1e12457
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 7851c0c into aws:main Aug 22, 2023
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 22, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@adriantaut
Copy link
Copy Markdown

adriantaut commented Aug 31, 2023

getting error with latest STANDARD_7_0 images while synthing in CDK Pipelines



[Container] 2023/08/31 08:47:39 Running command npm run build
--
51 |  
52 | > cdk@0.1.0 build
53 | > tsc
54 |  
55 |  
56 | [Container] 2023/08/31 08:48:02 Running command npx --version
57 | 9.5.1
58 |  
59 | [Container] 2023/08/31 08:48:03 Running command npx cdk synth
60 | /root/.npm/_npx/6c73beee0e79a1b5/node_modules/.bin/cdk: 1: use strict: not found
61 | /root/.npm/_npx/6c73beee0e79a1b5/node_modules/.bin/cdk: 2: Syntax error: word unexpected (expecting ")")

anyone facing the same? 🤔

@github-actions github-actions bot mentioned this pull request Sep 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rix0rrr rix0rrr rix0rrr approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees

No one assigned

Labels

effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes star-contributor [Pilot] contributed between 25-49 PRs to the CDK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

cdk-pipelines: Node 16 is approaching end-of-life

5 participants

@lpizzinidev @aws-cdk-automation @adriantaut @rix0rrr @mrgrain