feat(cloudfront): Add RealtimeLogConfig to Distribution#26808
feat(cloudfront): Add RealtimeLogConfig to Distribution#26808mergify[bot] merged 22 commits intoaws:mainfrom
Conversation
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
add snapshot
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
colifran
left a comment
There was a problem hiding this comment.
@jamiepmullan Thanks for getting this started! I left some initial comments for you to review.
update docs
add iam tests make name optional
jogold
left a comment
There was a problem hiding this comment.
Look great! A few more minor things...
|
@jogold thanks for the reviews! I really appreciate it |
|
|
||
| constructor(scope: Construct, id: string, props: RealtimeLogConfigProps) { | ||
| super(scope, id, { | ||
| physicalName: props.realtimeLogConfigName ?? Lazy.string({ produce: () => Names.uniqueId(this) }), |
There was a problem hiding this comment.
I think we prefer Names.uniqueResourceName for this. Also I don't think this needs to be Lazy
There was a problem hiding this comment.
Will revert this change...
There was a problem hiding this comment.
You need Lazy here otherwise you cannot call this because super() has not been called yet...
There was a problem hiding this comment.
in that case - do we want Names.uniqueId or Names.uniqueResourceName? (i assume the latter based on your previous comment)
colifran
left a comment
There was a problem hiding this comment.
@jamiepmullan Looking good! I added some comments. Thanks for your continued work on this :)
add region to arn
colifran
left a comment
There was a problem hiding this comment.
@jamiepmullan Great work! Thanks for your contribution.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Pull request to implement RealtimeLogConfig on CloudFront Distribution.
As well as being able to use
RealtimeLogConfigArnonDistribution, I also addedRealtimeLogConfigas a Construct so that the Cfn is abstracted too.The reason this is needed so that we can add realtime log config to a
Distributionwithout reverting to usingCfnDistribution.Closes #.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license