Skip to content

docs(events-targets): add link for Run an ECS task section#26805

Merged
mergify[bot] merged 3 commits intoaws:mainfrom
tam0ri:docs/add-link-for-ecs-run-task
Aug 18, 2023
Merged

docs(events-targets): add link for Run an ECS task section#26805
mergify[bot] merged 3 commits intoaws:mainfrom
tam0ri:docs/add-link-for-ecs-run-task

Conversation

@tam0ri
Copy link
Copy Markdown
Contributor

@tam0ri tam0ri commented Aug 18, 2023

README for aws-cdk-lib.aws_events_targets is missing the link for Run an ECS task section. This PR introduces the link.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Aug 18, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team August 18, 2023 12:36
@github-actions github-actions bot added the valued-contributor [Pilot] contributed between 6-12 PRs to the CDK label Aug 18, 2023
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Aug 18, 2023
lpizzinidev
lpizzinidev suggested changes Aug 18, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@lpizzinidev lpizzinidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! 👍
Another adjustment to make on this README: this header should start with a capital letter (Enable Amazon...)

@tam0ri tam0ri requested a review from lpizzinidev August 18, 2023 14:01
@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Aug 18, 2023
scanlonp
scanlonp approved these changes Aug 18, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@scanlonp scanlonp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good add

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 18, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Aug 18, 2023
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 18, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Aug 18, 2023

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 7318afc
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 3305d4f into aws:main Aug 18, 2023
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 18, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@github-actions github-actions bot mentioned this pull request Sep 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@lpizzinidev lpizzinidev lpizzinidev approved these changes

@scanlonp scanlonp scanlonp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

p2 valued-contributor [Pilot] contributed between 6-12 PRs to the CDK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tam0ri @aws-cdk-automation @lpizzinidev @scanlonp