fix(eks): undefined constructor in custom resource#26782
Conversation
When we [upgraded the proxy-agent v6](#26722) we did not update how we were importing from the package. Where [in 5.0 commonjs exports were used](https://github.com/TooTallNate/node-proxy-agent/blob/5.0.0/index.js#L25) , in [6.0 a named esm export is used](https://github.com/TooTallNate/proxy-agents/blob/proxy-agent%406.1.0/packages/proxy-agent/src/index.ts#L71). Updated to use a named import statement instead of a default require. Typescript also confirms the old import was an error now since we use `import` instead of `require`. Fixes: #26771
|
I ran the We should diffAssets on all of these tests but it results in needing to re-run them on a cadence that is currently intolerable without automation doing it for us. |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
When we upgraded the proxy-agent v6 we did not update how we were importing from the package. Where in 5.0 commonjs exports were used , in 6.0 a named esm export is used.
Updated to use a named import statement instead of a default require. Typescript also confirms the old import was an error now since we use
importinstead ofrequire.Fixes: #26771
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license