Skip to content

chore(cloudwatch): correct spelling error in alarm-base docstrings#26781

Merged
mergify[bot] merged 1 commit intoaws:mainfrom
7empestx:main
Aug 16, 2023
Merged

chore(cloudwatch): correct spelling error in alarm-base docstrings#26781
mergify[bot] merged 1 commit intoaws:mainfrom
7empestx:main

Conversation

@7empestx
Copy link
Copy Markdown
Contributor

@7empestx 7empestx commented Aug 16, 2023 •
edited by colifran
Loading

This PR fixes a spelling error in alarm-base docstrings for addAlarmAction, addInsufficientDataAction, and addOkAction where SnsAction was spelled SnsAcion.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 labels Aug 16, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team August 16, 2023 22:14
aws-cdk-automation
aws-cdk-automation previously requested changes Aug 16, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@colifran colifran changed the title spelling error fix in alarm-base.ts chore(cloudwatch): correct spelling error in alarm-base docstrings Aug 16, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review August 16, 2023 22:19

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Aug 16, 2023

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 9f8aa76
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Aug 16, 2023
colifran
colifran approved these changes Aug 16, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@colifran colifran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@7empestx Thanks for getting this corrected!

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 16, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit cef7136 into aws:main Aug 16, 2023
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Aug 16, 2023
@github-actions github-actions bot mentioned this pull request Sep 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

+1 more reviewer

@colifran colifran colifran approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@7empestx @aws-cdk-automation @colifran