Skip to content

chore(prlint): account for same user with multiple reviews#26765

Merged
mergify[bot] merged 2 commits intomainfrom
conroy/prlinteragain
Aug 15, 2023
Merged

chore(prlint): account for same user with multiple reviews#26765
mergify[bot] merged 2 commits intomainfrom
conroy/prlinteragain

Conversation

@kaizencc
Copy link
Copy Markdown
Contributor

@kaizencc kaizencc commented Aug 15, 2023

Apparently the same user can have both a COMMENTED review and a APPROVED review. See #26763 and the logs from its prlinter github action:

evaluation:  {
  "draft": false,
  "mergeable_state": "behind",
  "maintainerRequestedChanges": false,
  "maintainerApproved": false,
  "communityRequestedChanges": true, // also requested changes
  "communityApproved": true, // approved
  "userRequestsExemption": false
}

Also added more logging so that we can see the full data next time. This PR solves the issue by respecting APPROVED over COMMENTED. Any trusted reviewer who has APPROVED a PR will get the PR to pr/needs-maintainer-review. Maintainers can always dismiss those reviews if we find that we want to respect someone else's COMMENTED review.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Aug 15, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team August 15, 2023 19:18
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 15, 2023
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 15, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Aug 15, 2023

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: cd0445c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit b23252b into main Aug 15, 2023
@mergify mergify bot deleted the conroy/prlinteragain branch August 15, 2023 21:32
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 15, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@github-actions github-actions bot mentioned this pull request Sep 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@colifran colifran colifran approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kaizencc @aws-cdk-automation @colifran