fix(apigateway): StepFunctions integration adds unmodifiable methodresponses#26720
Closed
fix(apigateway): StepFunctions integration adds unmodifiable methodresponses#26720
Conversation
…esponses and Method methodResponses attributes
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
Author
|
No one seems to need this change. Closing until we get interest on it. |
|
I'm interested in this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
StepFunctionsIntegrationintegration can produce200,400or500status codes.To make its usage more convenient, it also adds default methodResponses for each of those statuses; if it didn't do this, the user would have to define the 3 method responses every time it uses the integration. However, the problem comes if the user wants to modify the default method responses. This is currently not possible, as
addMethodResponsewill just add to the array, adding multiple entries for the same statusCode, of which CloudFormation will deploy one nondeterministically and the rest is lost.This PR address this problem by adding a flag to
StepFunctionsIntegrationto disable adding the default method responses.If the user wants to customize, they will have to redefine all method responses.
Sister PR to #26718.
Relates to #26586 and #26636.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license