feat(opensearchservice): SAML authorization properties for Domain construct#26673
feat(opensearchservice): SAML authorization properties for Domain construct#26673mergify[bot] merged 5 commits intoaws:mainfrom
Conversation
| /** | ||
| * Container for information about the SAML configuration for OpenSearch Dashboards. | ||
| */ | ||
| readonly samlAuthenticationOptions?: SAMLOptionsProperty; |
There was a problem hiding this comment.
Could you add a default stating "no SAML authentication options"? - @default - no SAML authentication options
I also think we should add a note here saying that if SAML authentication options are set, then samlAuthenticationEnabled will be enabled
| }, | ||
| samlOptions: samlAuthenticationEnabled ? { | ||
| enabled: true, | ||
| idp: { |
There was a problem hiding this comment.
How about something like this so we can remove the ! operator:
idp: props.fineGrainedAccessControl && props.fineGrainedAccessControl.samlAuthenticationOptions ? {
entityId: props.fineGrainedAccessControl.samlAuthenticationOptions.idpEntityId,
metadataContent: props.fineGrainedAccessControl.samlAuthenticationOptions.idpMetadataContent,
} : undefined,What do you think?
| * This SAML user receives full permission in OpenSearch Dashboards/Kibana. | ||
| * Creating a new master username does not delete any existing master usernames. | ||
| */ | ||
| readonly masterUserName?: string; |
There was a problem hiding this comment.
Could you add a default flag?
| * The backend role that the SAML master user is mapped to. | ||
| * Any users with this backend role receives full permission in OpenSearch Dashboards/Kibana. | ||
| */ | ||
| readonly masterBackendRole?: string; |
There was a problem hiding this comment.
Could you add a default flag for this one too?
colifran
left a comment
There was a problem hiding this comment.
@lpizzinidev This looks great! I left a few minor comments.
colifran
left a comment
There was a problem hiding this comment.
@lpizzinidev Looks great! Thanks for your work on this.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
@lpizzinidev @colifran I don't see the docs having updated but I see the README.md was updated in this PR. Do you know when/how the docs will update?
|
Allows to specify SAML authentication for OpenSearch domains via high-level construct properties.
Example:
Closes #26600.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license