Skip to content

chore(lambda-nodejs): update docs for default runtime value#26664

Merged
mergify[bot] merged 1 commit intoaws:mainfrom
NathanTCz:NathanTCz-patch-1
Aug 7, 2023
Merged

chore(lambda-nodejs): update docs for default runtime value#26664
mergify[bot] merged 1 commit intoaws:mainfrom
NathanTCz:NathanTCz-patch-1

Conversation

@NathanTCz
Copy link
Copy Markdown
Contributor

The docs for NodeJsFunction say runtime defaults to NODEJS_14_X but the code defaults to lambda.Runtime.NODEJS_18_X (on function.ts:104)

Closes #26459.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team August 7, 2023 20:34
@github-actions github-actions bot added bug This issue is a bug. effort/medium Medium work item – several days of effort p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Aug 7, 2023
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@kaizencc kaizencc changed the title chore!: update docs for default runtime value chore(lambda-nodejs): update docs for default runtime value Aug 7, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review August 7, 2023 20:39

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 0960b2b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 7, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 60234de into aws:main Aug 7, 2023
@NathanTCz NathanTCz deleted the NathanTCz-patch-1 branch March 18, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. effort/medium Medium work item – several days of effort p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NodejsFunction: Inconsistent SDK behavior with and without runtime specification

3 participants