Skip to content

feat(app-staging-synthesizer): enable tag immutability#26656

Merged
mergify[bot] merged 3 commits intoaws:mainfrom
tenjaa:app-staging-synthesizer-immutable-ecr
Aug 17, 2023
Merged

feat(app-staging-synthesizer): enable tag immutability#26656
mergify[bot] merged 3 commits intoaws:mainfrom
tenjaa:app-staging-synthesizer-immutable-ecr

Conversation

@tenjaa
Copy link
Copy Markdown
Contributor

@tenjaa tenjaa commented Aug 7, 2023

Closes #26655

I cannot run the integration tests and therefore cannot update the snapshot :(

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Aug 7, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team August 7, 2023 12:49
@github-actions github-actions bot added bug This issue is a bug. p2 labels Aug 7, 2023
aws-cdk-automation
aws-cdk-automation previously requested changes Aug 7, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@tenjaa
Copy link
Copy Markdown
Contributor Author

tenjaa commented Aug 7, 2023

Exemption Request

This behavior was checked via snapshot in the past, so I think just checking it via snapshot should be fine.
Unfortunately I cannot update the snapshots, because I cannot run the integrations tests.

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Aug 7, 2023
@peterwoodworth peterwoodworth changed the title fix(app-staging-synthesizer): enable tag immutability feat(app-staging-synthesizer): enable tag immutability Aug 7, 2023
@github-actions github-actions bot added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. and removed bug This issue is a bug. labels Aug 7, 2023
@kaizencc kaizencc added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes and removed pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. labels Aug 17, 2023
@kaizencc kaizencc added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Aug 17, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review August 17, 2023 16:28

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Aug 17, 2023

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: ef70ef7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 17, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 0bcc4b4 into aws:main Aug 17, 2023
@github-actions github-actions bot mentioned this pull request Sep 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kaizencc kaizencc kaizencc approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees

No one assigned

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

app-staging-synthesizer: ecr repo not immutable

3 participants

@tenjaa @aws-cdk-automation @kaizencc