fix(rds): grantConnect fails to deploy when no user is specified for instances with secret credentials#26647
Conversation
…h secret credentials
There was a problem hiding this comment.
Looks good, and I'm ready to ship it! However, I'm noticing your PR titles have not followed the contributing guide best practices at least a couple of times, so I'm going to set this to "Request changes" to make sure that you see this comment 😇
Please make sure that your PR title confirms to the conventional commit standard (fix, feat, chore) and that it is written in a style that will reflect correctly in the change log. In particular, if this is a bug fix, please describe the bug that was fixed, not the change you made. (See Contributing Guide, Pull Requests)
Specifically, this part:
Titles for feat and fix PRs end up in the change log. Think about what makes most sense for users reading the changelog while writing them.
- feat: describe the feature (not the action of creating the commit or PR, for example, avoid words like "added" or "changed")
- fix: describe the bug (not the solution)
grantConnect fails to deploy when no user is specified for instances with secret credentials
|
@rix0rrr Thanks for the feedback 👍 |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Calling
grantConnecton instances with secret credentials not specifying the user was causing the deploy to fail because the secret was not resolved.This fix solves the bug.
Closes #26603.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license