docs(custom-resource): add example for AwsApiCall#26621
docs(custom-resource): add example for AwsApiCall#26621mergify[bot] merged 10 commits intoaws:mainfrom
Conversation
rix0rrr
left a comment
There was a problem hiding this comment.
Hey, thanks for this!
I was confused about how a user chooses between v2 and v3 on the custom resource, but I see from the README that it's done by registering a special fact. That information is missing here, which might be a bit confusing.
But I think we might change something about this construct anyway, so let's hold off on this change a little until we've settled on how it works.
|
Okay yeah, the v3 documentation is out of date. See the following PR: #26631 |
…o doc-custom-resource
|
@rix0rrr Thanks for your comments! |
I meant the other way around. It should all be only SDKv2-style strings. |
rix0rrr
left a comment
There was a problem hiding this comment.
I meant the other way around. It should all be only SDKv2-style strings.
…o doc-custom-resource
|
I see. I fixed it. |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
There weren't any examples for
AwsApiCallin the document other than the Overview.This commit adds examples to the document of
AwsApiCalland it helps users understand the usage.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license