fix(ecr): error handling compatible with aws sdk v3#26608
fix(ecr): error handling compatible with aws sdk v3#26608mergify[bot] merged 3 commits intoaws:mainfrom
Conversation
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
|
Exemption Request |
|
Looks like the app-staging-synthesizer-alpha package has a dependent integ snapshot that needs to be updated as well, otherwise I think this looks fine. Thank you for the catch @tmokmss, we made sure we caught all the error.code checks but error.name was available on only some errors in sdk v2 I'm assuming? |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
@MrArnoldPalmer
I guess |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Just fixing this in the same way as #26433
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license